chrome/android/java/src/org/chromium/chrome/browser/fullscreen/FullscreenManager.java - Issue 986963002: Allow fullscreen manager and control container to be null

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/fullscreen/FullscreenManager.java

Issue 986963002: Allow fullscreen manager and control container to be null (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressed more comments from tedchoc Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/fullscreen/FullscreenHtmlApiHandler.java ('k') | chrome/browser/android/compositor/layer/tab_layer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/fullscreen/FullscreenManager.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/fullscreen/FullscreenManager.java b/chrome/android/java/src/org/chromium/chrome/browser/fullscreen/FullscreenManager.java

index 3105128742161fae686c59827b9a5696a2ba0b99..1e0db06b3ed95065b63beffbd08fdf854a5d8e01 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/fullscreen/FullscreenManager.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/fullscreen/FullscreenManager.java

@@ -28,15 +28,10 @@ public abstract class FullscreenManager {

* @param window Top-level window to turn to fullscreen.

* @param modelSelector The model selector providing access to the current tab.

- * @param enabled Whether fullscreen is globally enabled.

- * @param persistentFullscreenSupported Whether persistent fullscreen via the HTML5 API is

- * enabled.

- public FullscreenManager(Window window, TabModelSelector modelSelector, boolean enabled,

- boolean persistentFullscreenSupported) {

+ public FullscreenManager(Window window, TabModelSelector modelSelector) {

mModelSelector = modelSelector;

- mHtmlApiHandler = new FullscreenHtmlApiHandler(

- window, createApiDelegate(), enabled && persistentFullscreenSupported);

+ mHtmlApiHandler = new FullscreenHtmlApiHandler(window, createApiDelegate());

mOverlayVideoMode = false;

}