Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/fullscreen/FullscreenHtmlApiHandler.java

Issue 986963002: Allow fullscreen manager and control container to be null (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: addressed more comments from tedchoc Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/fullscreen/FullscreenHtmlApiHandler.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/fullscreen/FullscreenHtmlApiHandler.java b/chrome/android/java/src/org/chromium/chrome/browser/fullscreen/FullscreenHtmlApiHandler.java
index 6f16a74d1e3bddcc61b5f7af16c7748e655bcea6..c049a5023a9ba9e4f7ef4c5d6a833ad57c0a564d 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/fullscreen/FullscreenHtmlApiHandler.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/fullscreen/FullscreenHtmlApiHandler.java
@@ -55,8 +55,6 @@ public class FullscreenHtmlApiHandler {
private final FullscreenHtmlApiDelegate mDelegate;
private final int mNotificationMaxDimension;
- private final boolean mPersistentFullscreenSupported;
-
// We still need this since we are setting fullscreen UI state on the contentviewcore's
// container view, and a tab can have null content view core, i.e., if you navigate
// to a native page.
@@ -193,13 +191,10 @@ public class FullscreenHtmlApiHandler {
*
* @param window The window containing the view going to fullscreen.
* @param delegate The delegate that allows embedders to handle fullscreen transitions.
- * @param persistentFullscreenSupported
*/
- public FullscreenHtmlApiHandler(Window window, FullscreenHtmlApiDelegate delegate,
- boolean persistentFullscreenSupported) {
+ public FullscreenHtmlApiHandler(Window window, FullscreenHtmlApiDelegate delegate) {
mWindow = window;
mDelegate = delegate;
- mPersistentFullscreenSupported = persistentFullscreenSupported;
mHandler = new FullscreenHandler(this);
Resources resources = mWindow.getContext().getResources();
float density = resources.getDisplayMetrics().density;
@@ -213,8 +208,6 @@ public class FullscreenHtmlApiHandler {
* @param enabled Whether to enable persistent fullscreen mode.
*/
public void setPersistentFullscreenMode(boolean enabled) {
- if (!mPersistentFullscreenSupported) return;
-
if (mIsPersistentMode == enabled) return;
mIsPersistentMode = enabled;

Powered by Google App Engine
This is Rietveld 408576698