chrome/browser/resources/settings/settings_menu/settings_menu.js - Issue 986843002: Scaffold for MD-Settings, inside chrome://md-settings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/settings_menu/settings_menu.js

Issue 986843002: Scaffold for MD-Settings, inside chrome://md-settings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Expand scaffold and add to chrome://md-settings (point of this CL) Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/settings_menu/settings_menu.html ('k') | chrome/browser/resources/settings/settings_page/settings_page.css » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/settings_menu/settings_menu.js

diff --git a/chrome/browser/resources/settings/settings_menu/settings_menu.js b/chrome/browser/resources/settings/settings_menu/settings_menu.js

index ec2108a9e00f50041aba437abd64d9ec9a2a35cb..3477c8ed5c0c7a935bcd86bd04ba0adb9a74e771 100644

--- a/chrome/browser/resources/settings/settings_menu/settings_menu.js

+++ b/chrome/browser/resources/settings/settings_menu/settings_menu.js

@@ -8,7 +8,7 @@

* Example:

- * <cr-settings-menu pages="{{pages}}" selectedId="{{selectedId}}">

+ * <cr-settings-menu pages="{{pages}}" selectedIndex="{{index}}">

* </cr-settings-menu>

* @group Chrome Settings Elements

@@ -20,7 +20,7 @@ Polymer('cr-settings-menu', {

* Pages to show menu items for.

* @attribute pages

- * @type Array<!Object>

+ * @type Array<!CrSettingsPage>

* @default null

pages: null,

@@ -28,11 +28,20 @@ Polymer('cr-settings-menu', {

/**

* ID of the currently selected page.

- * @attribute selectedId

+ * @attribute selectedIndex

* @type string

* default ''

selectedId: '',

+ /**

+ * Index of the currently selected page.

+ *

+ * @attribute selectedIndex

+ * @type number

+ * default 0

+ */

+ selectedIndex: 0,

/** @override */