chrome/browser/resources/settings/settings_menu/settings_menu.html - Issue 986843002: Scaffold for MD-Settings, inside chrome://md-settings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/settings_menu/settings_menu.html

Issue 986843002: Scaffold for MD-Settings, inside chrome://md-settings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Expand scaffold and add to chrome://md-settings (point of this CL) Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/settings_main/settings_main.js ('k') | chrome/browser/resources/settings/settings_menu/settings_menu.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/settings_menu/settings_menu.html

diff --git a/chrome/browser/resources/settings/settings_menu/settings_menu.html b/chrome/browser/resources/settings/settings_menu/settings_menu.html

index 5b71c1c91b31399da1661712de394e2196379e5a..3eba1f088c689054e669d1f628bf92b90b6866d0 100644

--- a/chrome/browser/resources/settings/settings_menu/settings_menu.html

+++ b/chrome/browser/resources/settings/settings_menu/settings_menu.html

@@ -4,7 +4,8 @@

<polymer-element name="cr-settings-menu">

- <core-menu selected="{{selectedId}}" valueattr="data-id">

+ <core-menu id="menu" selectedIndex="{{selectedIndex}}"

+ selected="{{selectedId}}" valueattr="data-id">

<paper-item data-id="{{PAGE_ID}}">

<core-icon icon="{{icon}}"></core-icon>