Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Issue 98673003: Fix HInnerAllocatedObject to use an HValue for the offset. (Closed)

Created:
7 years ago by Benedikt Meurer
Modified:
7 years ago
CC:
v8-dev
Visibility:
Public.

Description

Fix HInnerAllocatedObject to use an HValue for the offset. R=hpayer@chromium.org, mvstanton@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18181

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -88 lines) Patch
M src/arm/lithium-arm.h View 1 chunk +6 lines, -6 lines 0 comments Download
M src/arm/lithium-arm.cc View 2 chunks +7 lines, -6 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 chunk +7 lines, -1 line 0 comments Download
M src/code-stubs-hydrogen.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/hydrogen.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/hydrogen.cc View 4 chunks +31 lines, -33 lines 0 comments Download
M src/hydrogen-instructions.h View 2 chunks +9 lines, -8 lines 0 comments Download
M src/hydrogen-instructions.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 chunk +7 lines, -1 line 0 comments Download
M src/ia32/lithium-ia32.h View 1 chunk +6 lines, -6 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 2 chunks +7 lines, -6 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 chunk +7 lines, -1 line 0 comments Download
M src/x64/lithium-x64.h View 1 chunk +6 lines, -6 lines 0 comments Download
M src/x64/lithium-x64.cc View 2 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Benedikt Meurer
Hey Michael, Next step on the "BinaryOpIC with allocation site" road. We have to fix ...
7 years ago (2013-12-02 10:14:59 UTC) #1
mvstanton
Hi Benedikt, looks good. Can you do two things: 1) Get Hannes to have a ...
7 years ago (2013-12-02 10:25:49 UTC) #2
Benedikt Meurer
7 years ago (2013-12-02 10:26:55 UTC) #3
Benedikt Meurer
> 2) Can you verify by looking at the generated code for, say, a ordinary ...
7 years ago (2013-12-02 10:37:19 UTC) #4
Hannes Payer (out of office)
LGTM
7 years ago (2013-12-02 10:48:02 UTC) #5
Benedikt Meurer
7 years ago (2013-12-02 11:24:43 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 manually as r18181 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698