Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Side by Side Diff: src/ia32/lithium-ia32.cc

Issue 98673003: Fix HInnerAllocatedObject to use an HValue for the offset. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/lithium-ia32.h ('k') | src/x64/lithium-codegen-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 284 matching lines...) Expand 10 before | Expand all | Expand 10 after
295 stream->Add(" = "); 295 stream->Add(" = ");
296 function()->PrintTo(stream); 296 function()->PrintTo(stream);
297 stream->Add(".code_entry = "); 297 stream->Add(".code_entry = ");
298 code_object()->PrintTo(stream); 298 code_object()->PrintTo(stream);
299 } 299 }
300 300
301 301
302 void LInnerAllocatedObject::PrintDataTo(StringStream* stream) { 302 void LInnerAllocatedObject::PrintDataTo(StringStream* stream) {
303 stream->Add(" = "); 303 stream->Add(" = ");
304 base_object()->PrintTo(stream); 304 base_object()->PrintTo(stream);
305 stream->Add(" + %d", offset()); 305 stream->Add(" + ");
306 offset()->PrintTo(stream);
306 } 307 }
307 308
308 309
309 void LCallConstantFunction::PrintDataTo(StringStream* stream) { 310 void LCallConstantFunction::PrintDataTo(StringStream* stream) {
310 stream->Add("#%d / ", arity()); 311 stream->Add("#%d / ", arity());
311 } 312 }
312 313
313 314
314 void LLoadContextSlot::PrintDataTo(StringStream* stream) { 315 void LLoadContextSlot::PrintDataTo(StringStream* stream) {
315 context()->PrintTo(stream); 316 context()->PrintTo(stream);
(...skipping 878 matching lines...) Expand 10 before | Expand all | Expand 10 after
1194 1195
1195 LInstruction* LChunkBuilder::DoStoreCodeEntry( 1196 LInstruction* LChunkBuilder::DoStoreCodeEntry(
1196 HStoreCodeEntry* store_code_entry) { 1197 HStoreCodeEntry* store_code_entry) {
1197 LOperand* function = UseRegister(store_code_entry->function()); 1198 LOperand* function = UseRegister(store_code_entry->function());
1198 LOperand* code_object = UseTempRegister(store_code_entry->code_object()); 1199 LOperand* code_object = UseTempRegister(store_code_entry->code_object());
1199 return new(zone()) LStoreCodeEntry(function, code_object); 1200 return new(zone()) LStoreCodeEntry(function, code_object);
1200 } 1201 }
1201 1202
1202 1203
1203 LInstruction* LChunkBuilder::DoInnerAllocatedObject( 1204 LInstruction* LChunkBuilder::DoInnerAllocatedObject(
1204 HInnerAllocatedObject* inner_object) { 1205 HInnerAllocatedObject* instr) {
1205 LOperand* base_object = UseRegisterAtStart(inner_object->base_object()); 1206 LOperand* base_object = UseRegisterAtStart(instr->base_object());
1206 LInnerAllocatedObject* result = 1207 LOperand* offset = UseRegisterOrConstantAtStart(instr->offset());
1207 new(zone()) LInnerAllocatedObject(base_object); 1208 return DefineAsRegister(
1208 return DefineAsRegister(result); 1209 new(zone()) LInnerAllocatedObject(base_object, offset));
1209 } 1210 }
1210 1211
1211 1212
1212 LInstruction* LChunkBuilder::DoThisFunction(HThisFunction* instr) { 1213 LInstruction* LChunkBuilder::DoThisFunction(HThisFunction* instr) {
1213 return instr->HasNoUses() 1214 return instr->HasNoUses()
1214 ? NULL 1215 ? NULL
1215 : DefineAsRegister(new(zone()) LThisFunction); 1216 : DefineAsRegister(new(zone()) LThisFunction);
1216 } 1217 }
1217 1218
1218 1219
(...skipping 1569 matching lines...) Expand 10 before | Expand all | Expand 10 after
2788 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) { 2789 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) {
2789 LOperand* object = UseRegister(instr->object()); 2790 LOperand* object = UseRegister(instr->object());
2790 LOperand* index = UseTempRegister(instr->index()); 2791 LOperand* index = UseTempRegister(instr->index());
2791 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index)); 2792 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index));
2792 } 2793 }
2793 2794
2794 2795
2795 } } // namespace v8::internal 2796 } } // namespace v8::internal
2796 2797
2797 #endif // V8_TARGET_ARCH_IA32 2798 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/ia32/lithium-ia32.h ('k') | src/x64/lithium-codegen-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698