Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2414)

Unified Diff: dart/sdk/lib/_internal/compiler/implementation/compiler.dart

Issue 98663003: Don't emit unused hints when there are compilation errors. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | dart/tests/compiler/dart2js/diagnose_ambiguous_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/sdk/lib/_internal/compiler/implementation/compiler.dart
diff --git a/dart/sdk/lib/_internal/compiler/implementation/compiler.dart b/dart/sdk/lib/_internal/compiler/implementation/compiler.dart
index 1f23e063f50c707cbefaf22444b4a7f1636672ae..7ac0ee94a50b21e75c2580cfa99aec52da81d76e 100644
--- a/dart/sdk/lib/_internal/compiler/implementation/compiler.dart
+++ b/dart/sdk/lib/_internal/compiler/implementation/compiler.dart
@@ -1087,6 +1087,7 @@ abstract class Compiler implements DiagnosticListener {
processQueue(enqueuer.resolution, main);
enqueuer.resolution.logSummary(log);
+ if (compilationFailed) return;
if (analyzeOnly) {
if (!analyzeAll) {
// No point in reporting unused code when [analyzeAll] is true: all
@@ -1095,7 +1096,6 @@ abstract class Compiler implements DiagnosticListener {
}
return;
}
- if (compilationFailed) return;
assert(main != null);
phase = PHASE_DONE_RESOLVING;
« no previous file with comments | « no previous file | dart/tests/compiler/dart2js/diagnose_ambiguous_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698