Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Unified Diff: dart/tests/compiler/dart2js/diagnose_ambiguous_test.dart

Issue 98663003: Don't emit unused hints when there are compilation errors. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dart/sdk/lib/_internal/compiler/implementation/compiler.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/tests/compiler/dart2js/diagnose_ambiguous_test.dart
diff --git a/dart/tests/compiler/dart2js/diagnose_ambiguous_test.dart b/dart/tests/compiler/dart2js/diagnose_ambiguous_test.dart
index fd12f2cb57ece9d1c2ed839cfa94ca5a0ec3c5df..5e93e2e29500ed1ef76b8d0c806ebcbd8e382a56 100644
--- a/dart/tests/compiler/dart2js/diagnose_ambiguous_test.dart
+++ b/dart/tests/compiler/dart2js/diagnose_ambiguous_test.dart
@@ -14,8 +14,6 @@ main() {
Uri libraryRoot = script.resolve('../../../sdk/');
Uri packageRoot = script.resolve('./packages/');
- var unusedPattern = new RegExp("Hint: The method '.*' is never called\\.");
-
var provider = new MemorySourceFileProvider(MEMORY_SOURCE_FILES);
var diagnostics = [];
void diagnosticHandler(Uri uri, int begin, int end,
@@ -23,9 +21,6 @@ main() {
if (kind == Diagnostic.VERBOSE_INFO) {
return;
}
- if (message.startsWith(unusedPattern)) {
- return;
- }
diagnostics.add('$uri:$begin:$end:$message:$kind');
}
« no previous file with comments | « dart/sdk/lib/_internal/compiler/implementation/compiler.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698