Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Unified Diff: Source/bindings/core/v8/V8ErrorHandler.cpp

Issue 986573002: bindings: Use BooleanValue(v8::Context) in V8ErrorHandler (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/core/v8/V8ErrorHandler.cpp
diff --git a/Source/bindings/core/v8/V8ErrorHandler.cpp b/Source/bindings/core/v8/V8ErrorHandler.cpp
index f482e4873c3fb080343ade5d5e2d20a8d79eec7a..87d7bdefb4250e1a5e53d4115a8a93fcb407635b 100644
--- a/Source/bindings/core/v8/V8ErrorHandler.cpp
+++ b/Source/bindings/core/v8/V8ErrorHandler.cpp
@@ -89,7 +89,7 @@ void V8ErrorHandler::storeExceptionOnErrorEventWrapper(v8::Isolate* isolate, Err
bool V8ErrorHandler::shouldPreventDefault(v8::Local<v8::Value> returnValue)
{
- return returnValue->IsBoolean() && returnValue->BooleanValue();
+ return returnValue->IsBoolean() && returnValue->BooleanValue(isolate()->GetCurrentContext()).FromJust();
bashi 2015/03/06 07:16:18 Correct me if I'm wrong: I assume that BooleanValu
dcarney 2015/03/06 07:32:26 If you know the object's type exactly, always use
}
} // namespace blink
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698