Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Side by Side Diff: Source/bindings/core/v8/V8ErrorHandler.cpp

Issue 986573002: bindings: Use BooleanValue(v8::Context) in V8ErrorHandler (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 71 matching lines...) Expand 10 before | Expand all | Expand 10 after
82 { 82 {
83 v8::Local<v8::Value> wrappedEvent = toV8(event, creationContext, isolate); 83 v8::Local<v8::Value> wrappedEvent = toV8(event, creationContext, isolate);
84 if (!wrappedEvent.IsEmpty()) { 84 if (!wrappedEvent.IsEmpty()) {
85 ASSERT(wrappedEvent->IsObject()); 85 ASSERT(wrappedEvent->IsObject());
86 V8HiddenValue::setHiddenValue(isolate, v8::Local<v8::Object>::Cast(wrapp edEvent), V8HiddenValue::error(isolate), data); 86 V8HiddenValue::setHiddenValue(isolate, v8::Local<v8::Object>::Cast(wrapp edEvent), V8HiddenValue::error(isolate), data);
87 } 87 }
88 } 88 }
89 89
90 bool V8ErrorHandler::shouldPreventDefault(v8::Local<v8::Value> returnValue) 90 bool V8ErrorHandler::shouldPreventDefault(v8::Local<v8::Value> returnValue)
91 { 91 {
92 return returnValue->IsBoolean() && returnValue->BooleanValue(); 92 return returnValue->IsBoolean() && returnValue->BooleanValue(isolate()->GetC urrentContext()).FromJust();
bashi 2015/03/06 07:16:18 Correct me if I'm wrong: I assume that BooleanValu
dcarney 2015/03/06 07:32:26 If you know the object's type exactly, always use
93 } 93 }
94 94
95 } // namespace blink 95 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698