Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 /* | 1 /* |
| 2 * Copyright (C) 2010 Google Inc. All rights reserved. | 2 * Copyright (C) 2010 Google Inc. All rights reserved. |
| 3 * | 3 * |
| 4 * Redistribution and use in source and binary forms, with or without | 4 * Redistribution and use in source and binary forms, with or without |
| 5 * modification, are permitted provided that the following conditions are | 5 * modification, are permitted provided that the following conditions are |
| 6 * met: | 6 * met: |
| 7 * | 7 * |
| 8 * * Redistributions of source code must retain the above copyright | 8 * * Redistributions of source code must retain the above copyright |
| 9 * notice, this list of conditions and the following disclaimer. | 9 * notice, this list of conditions and the following disclaimer. |
| 10 * * Redistributions in binary form must reproduce the above | 10 * * Redistributions in binary form must reproduce the above |
| (...skipping 71 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 82 { | 82 { |
| 83 v8::Local<v8::Value> wrappedEvent = toV8(event, creationContext, isolate); | 83 v8::Local<v8::Value> wrappedEvent = toV8(event, creationContext, isolate); |
| 84 if (!wrappedEvent.IsEmpty()) { | 84 if (!wrappedEvent.IsEmpty()) { |
| 85 ASSERT(wrappedEvent->IsObject()); | 85 ASSERT(wrappedEvent->IsObject()); |
| 86 V8HiddenValue::setHiddenValue(isolate, v8::Local<v8::Object>::Cast(wrapp edEvent), V8HiddenValue::error(isolate), data); | 86 V8HiddenValue::setHiddenValue(isolate, v8::Local<v8::Object>::Cast(wrapp edEvent), V8HiddenValue::error(isolate), data); |
| 87 } | 87 } |
| 88 } | 88 } |
| 89 | 89 |
| 90 bool V8ErrorHandler::shouldPreventDefault(v8::Local<v8::Value> returnValue) | 90 bool V8ErrorHandler::shouldPreventDefault(v8::Local<v8::Value> returnValue) |
| 91 { | 91 { |
| 92 return returnValue->IsBoolean() && returnValue->BooleanValue(); | 92 return returnValue->IsBoolean() && returnValue->BooleanValue(isolate()->GetC urrentContext()).FromJust(); |
|
bashi
2015/03/06 07:16:18
Correct me if I'm wrong: I assume that BooleanValu
dcarney
2015/03/06 07:32:26
If you know the object's type exactly, always use
| |
| 93 } | 93 } |
| 94 | 94 |
| 95 } // namespace blink | 95 } // namespace blink |
| OLD | NEW |