Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Unified Diff: build/common.gypi

Issue 986503002: components/metrics: Add runtime memory leak detector (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove dummy function; Exclude sources if leak_detector!=1; Add headers to sources! Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 70d2ec571f5181e5207aa9f2df232e9a5445eab8..ca4037d91231cdbe50a1ead9bb2e484f8bf46063 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -1364,6 +1364,9 @@
# Profile without optimizing out stack frames when profiling==1.
'profiling_full_stack_frames%': '0',
+ # Enable automatic leak detector.
+ 'leak_detector%': 0,
+
# And if we want to dump symbols for Breakpad-enabled builds.
'linux_dump_symbols%': 0,
# And if we want to strip the binary after dumping symbols.
@@ -2707,6 +2710,9 @@
['profiling==1', {
'defines': ['ENABLE_PROFILING=1'],
}],
+ ['leak_detector==1 and chromeos==1', {
+ 'defines': ['ENABLE_LEAK_DETECTOR=1'],
+ }],
['remoting==1', {
'defines': ['ENABLE_REMOTING=1'],
}],
@@ -3815,6 +3821,12 @@
'release_optimize%': 's',
},
}],
+ ['leak_detector==1 and chromeos==1', {
+ 'cflags': [
+ '-fno-omit-frame-pointer',
+ '-g',
Nico 2015/07/16 19:31:24 Including full debug symbols in all chromeos build
Simon Que 2015/07/16 21:15:08 The '-g' isn't necessary; I'm getting rid of it.
+ ],
+ }],
['profiling==1', {
'cflags': [
'-fno-omit-frame-pointer',

Powered by Google App Engine
This is Rietveld 408576698