third_party/tcmalloc/chromium/src/base/commandlineflags.h - Issue 986503002: components/metrics: Add runtime memory leak detector

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/tcmalloc/chromium/src/base/commandlineflags.h

Issue 986503002: components/metrics: Add runtime memory leak detector (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove dummy function; Exclude sources if leak_detector!=1; Add headers to sources! Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/tcmalloc/chromium/src/base/commandlineflags.h

diff --git a/third_party/tcmalloc/chromium/src/base/commandlineflags.h b/third_party/tcmalloc/chromium/src/base/commandlineflags.h

index 614be3a1a6bca90ebd621793f0c8c4033a5f7727..e67511cd5e97e4f07a32d73415face42dcf1b8df 100644

--- a/third_party/tcmalloc/chromium/src/base/commandlineflags.h

+++ b/third_party/tcmalloc/chromium/src/base/commandlineflags.h

@@ -118,7 +118,7 @@

// They are functions in Android because __system_property_get() doesn't

// return a string.

-#if defined(ENABLE_PROFILING)

+#if defined(ENABLE_PROFILING) || defined(ENABLE_LEAK_DETECTOR)

Nico 2015/07/16 19:49:09 This too means you can never ship this to users –

Simon Que 2015/07/16 21:15:08 Then the problem may extend beyond this file. I am

Nico 2015/07/16 21:25:17 Yes.

#if defined(__ANDROID__) || defined(ANDROID)

« build/common.gypi ('K') | « third_party/tcmalloc/README.chromium ('k') | third_party/tcmalloc/chromium/src/base/custom_allocator.h » ('j') | no next file with comments »