Source/platform/fonts/shaping/HarfBuzzShaper.h - Issue 986493002: Simplify text emphasis painting

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/fonts/shaping/HarfBuzzShaper.h

Issue 986493002: Simplify text emphasis painting (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/platform/fonts/Font.h ('K') | « Source/platform/fonts/Font.cpp ('k') | Source/platform/fonts/shaping/HarfBuzzShaper.cpp » ('j') | Source/platform/fonts/shaping/SimpleShaper.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/platform/fonts/shaping/HarfBuzzShaper.h

diff --git a/Source/platform/fonts/shaping/HarfBuzzShaper.h b/Source/platform/fonts/shaping/HarfBuzzShaper.h

index 55305e7cc13eb310cd612fe51786c4fe70d6a851..a2b6acad5a8850ac6041bbb684eea89189ecc9cf 100644

--- a/Source/platform/fonts/shaping/HarfBuzzShaper.h

+++ b/Source/platform/fonts/shaping/HarfBuzzShaper.h

@@ -52,7 +52,8 @@ class SimpleFontData;

class HarfBuzzShaper final : public Shaper {

public:

- HarfBuzzShaper(const Font*, const TextRun&, ForTextEmphasisOrNot = NotForTextEmphasis, HashSet<const SimpleFontData*>* fallbackFonts = 0, FloatRect* = 0);

+ HarfBuzzShaper(const Font*, const TextRun&, const GlyphData* emphasisData = nullptr,

+ HashSet<const SimpleFontData*>* fallbackFonts = nullptr, FloatRect* = nullptr);

void setDrawRange(int from, int to);

bool shape(GlyphBuffer* = 0);

« Source/platform/fonts/Font.h ('K') | « Source/platform/fonts/Font.cpp ('k') | Source/platform/fonts/shaping/HarfBuzzShaper.cpp » ('j') | Source/platform/fonts/shaping/SimpleShaper.cpp » ('J')