Chromium Code Reviews| Index: Source/platform/fonts/Font.h |
| diff --git a/Source/platform/fonts/Font.h b/Source/platform/fonts/Font.h |
| index 73144797476e6e577f82d66849495275a844f78b..cc22b1c3100f52e07a5971f64a38278d1d67efb6 100644 |
| --- a/Source/platform/fonts/Font.h |
| +++ b/Source/platform/fonts/Font.h |
| @@ -138,7 +138,7 @@ private: |
| enum ForTextEmphasisOrNot { NotForTextEmphasis, ForTextEmphasis }; |
| // Returns the total advance. |
| - float buildGlyphBuffer(const TextRunPaintInfo&, GlyphBuffer&, ForTextEmphasisOrNot = NotForTextEmphasis) const; |
| + float buildGlyphBuffer(const TextRunPaintInfo&, GlyphBuffer&, const GlyphData* = nullptr) const; |
|
jbroman
2015/03/07 18:50:25
Please include a name for this argument; it's not
f(malita)
2015/03/09 15:04:55
Done.
|
| PassTextBlobPtr buildTextBlob(const GlyphBuffer&) const; |
| SkPaint textFillPaint(GraphicsContext*, const SimpleFontData*) const; |
| SkPaint textStrokePaint(GraphicsContext*, const SimpleFontData*, bool isFilling) const; |
| @@ -151,7 +151,6 @@ private: |
| void drawGlyphs(GraphicsContext*, const SimpleFontData*, const GlyphBuffer&, unsigned from, unsigned numGlyphs, const FloatPoint&, const FloatRect& textRect) const; |
| void drawTextBlob(GraphicsContext*, const SkTextBlob*, const SkPoint& origin) const; |
| void drawGlyphBuffer(GraphicsContext*, const TextRunPaintInfo&, const GlyphBuffer&, const FloatPoint&) const; |
| - void drawEmphasisMarks(GraphicsContext*, const TextRunPaintInfo&, const GlyphBuffer&, const AtomicString&, const FloatPoint&) const; |
| float floatWidthForSimpleText(const TextRun&, HashSet<const SimpleFontData*>* fallbackFonts = 0, IntRectOutsets* glyphBounds = 0) const; |
| int offsetForPositionForSimpleText(const TextRun&, float position, bool includePartialGlyphs) const; |
| FloatRect selectionRectForSimpleText(const TextRun&, const FloatPoint&, int h, int from, int to, bool accountForGlyphBounds) const; |