Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Unified Diff: unittests/Bitcode/NaClParseInstsTest.cpp

Issue 986453002: Additional clean ups on errors in bitcode parsing. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-llvm.git@master
Patch Set: Fix comment. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « unittests/Bitcode/NaClObjDumpTest.cpp ('k') | unittests/Bitcode/NaClParseTypesTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: unittests/Bitcode/NaClParseInstsTest.cpp
diff --git a/unittests/Bitcode/NaClParseInstsTest.cpp b/unittests/Bitcode/NaClParseInstsTest.cpp
index a8f555d5abe8b2ed3b657c8d967d97fc34eee832..8b0a882a30f9082381767b1bb12e2282372a307a 100644
--- a/unittests/Bitcode/NaClParseInstsTest.cpp
+++ b/unittests/Bitcode/NaClParseInstsTest.cpp
@@ -90,7 +90,7 @@ TEST(NaClParseInstsTest, NonexistantCallArg) {
array_lengthof(BitcodeRecords), Terminator);
EXPECT_FALSE(Munger.runTest("Nonexistant call arg", true));
EXPECT_EQ(
- "Error: (72:6) Invalid call argument: Index 1\n"
+ "Error(72:6): Invalid call argument: Index 1\n"
"Error: Invalid value in record\n",
Munger.getTestResults());
}
@@ -173,7 +173,7 @@ TEST(NaClParseInstsTests, BadAllocaAlignment) {
EXPECT_FALSE(Munger.runTest(
"BadAllocaAlignment-30", Align30, array_lengthof(Align30), true));
EXPECT_EQ(
- "Error: (65:6) Alignment can't be greater than 2**29. Found: 2**30\n"
+ "Error(65:6): Alignment can't be greater than 2**29. Found: 2**30\n"
"Error: Invalid value in record\n",
Munger.getTestResults());
EXPECT_FALSE(DumpMunger.runTestForAssembly(
@@ -309,7 +309,7 @@ TEST(NaClParseInstsTests, BadLoadAlignment) {
EXPECT_FALSE(Munger.runTest(
"BadLoadAlignment-30", Align30, array_lengthof(Align30), true));
EXPECT_EQ(
- "Error: (62:4) Alignment can't be greater than 2**29. Found: 2**30\n"
+ "Error(62:4): Alignment can't be greater than 2**29. Found: 2**30\n"
"Error: Invalid value in record\n",
Munger.getTestResults());
EXPECT_FALSE(DumpMunger.runTestForAssembly(
@@ -441,7 +441,7 @@ TEST(NaClParseInstsTests, BadStoreAlignment) {
EXPECT_FALSE(Munger.runTest(
"BadStoreAlignment-30", Align30, array_lengthof(Align30), true));
EXPECT_EQ(
- "Error: (66:4) Alignment can't be greater than 2**29. Found: 2**30\n"
+ "Error(66:4): Alignment can't be greater than 2**29. Found: 2**30\n"
"Error: Invalid value in record\n",
Munger.getTestResults());
EXPECT_FALSE(DumpMunger.runTestForAssembly(
« no previous file with comments | « unittests/Bitcode/NaClObjDumpTest.cpp ('k') | unittests/Bitcode/NaClParseTypesTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698