Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Unified Diff: unittests/Bitcode/NaClObjDumpTest.cpp

Issue 986453002: Additional clean ups on errors in bitcode parsing. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-llvm.git@master
Patch Set: Fix comment. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « unittests/Bitcode/NaClAbbrevErrorTests.cpp ('k') | unittests/Bitcode/NaClParseInstsTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: unittests/Bitcode/NaClObjDumpTest.cpp
diff --git a/unittests/Bitcode/NaClObjDumpTest.cpp b/unittests/Bitcode/NaClObjDumpTest.cpp
index d685e7880a47c6bb3dc09beabe24899bde27a626..dc382b4cf1dc4126902cbf633dc441b04c4a684b 100644
--- a/unittests/Bitcode/NaClObjDumpTest.cpp
+++ b/unittests/Bitcode/NaClObjDumpTest.cpp
@@ -42,14 +42,14 @@ static void RunAssemblyExamples(
// First assume no assembly.
if (AddErrors)
- Stream.Error(Bit) << "This is an error\n";
+ Stream.ErrorAt(Bit) << "This is an error\n";
Write(Stream, Bit, Record, AbbrevIndex);
// Increment bit to new fictitious address, assuming Record takes 21 bits.
Bit += 21;
// Now a single line assembly.
if (AddErrors)
- Stream.Error(Bit) << "Oops, an error!\n";
+ Stream.ErrorAt(Bit) << "Oops, an error!\n";
Stream.Assembly() << "One line assembly.";
Write(Stream, Bit, Record, AbbrevIndex);
// Increment bit to new fictitious address, assuming Record takes 17 bits.
@@ -57,10 +57,10 @@ static void RunAssemblyExamples(
// Now multiple line assembly.
if (AddErrors)
- Stream.Error(Bit) << "The record looks bad\n";
+ Stream.ErrorAt(Bit) << "The record looks bad\n";
Stream.Assembly() << "Two Line\nexample assembly.";
if (AddErrors)
- Stream.Error(Bit) << "Actually, it looks really bad\n";
+ Stream.ErrorAt(Bit) << "Actually, it looks really bad\n";
Write(Stream, Bit, Record, AbbrevIndex);
}
« no previous file with comments | « unittests/Bitcode/NaClAbbrevErrorTests.cpp ('k') | unittests/Bitcode/NaClParseInstsTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698