unittests/Bitcode/NaClAbbrevErrorTests.cpp - Issue 986453002: Additional clean ups on errors in bitcode parsing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: unittests/Bitcode/NaClAbbrevErrorTests.cpp

Issue 986453002: Additional clean ups on errors in bitcode parsing. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-llvm.git@master

Patch Set: Fix comment. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: unittests/Bitcode/NaClAbbrevErrorTests.cpp

diff --git a/unittests/Bitcode/NaClAbbrevErrorTests.cpp b/unittests/Bitcode/NaClAbbrevErrorTests.cpp

index 56b3c2f45cd332902b350e4b1d3aacd260ef6cae..fbe18bc3c0038a05b001fc500b7381ffffa086cc 100644

--- a/unittests/Bitcode/NaClAbbrevErrorTests.cpp

+++ b/unittests/Bitcode/NaClAbbrevErrorTests.cpp

@@ -79,7 +79,7 @@ TEST(MyDeathNaClAbbrevErrorTests, BadAbbreviationIndex) {

EXPECT_DEATH(

DumpMunger.runTest("Bad abbreviation index 4",

AbbrevIndex4, array_lengthof(AbbrevIndex4)),

- ".*Error\\(35\\:0\\)\\: Invalid abbreviation \\# 4 defined for record.*");

+ ".*Fatal\\(35\\:0\\)\\: Invalid abbreviation \\# 4 defined for record.*");

// Test that bitcode reader reports problem correctly.

NaClParseBitcodeMunger Munger(BitcodeRecords,

@@ -87,7 +87,7 @@ TEST(MyDeathNaClAbbrevErrorTests, BadAbbreviationIndex) {

EXPECT_DEATH(

Munger.runTest("Bad abbreviation index",

AbbrevIndex4, array_lengthof(AbbrevIndex4), true),

- ".*Error\\(35\\:0\\)\\: Invalid abbreviation \\# 4 defined for record.*");

+ ".*Fatal\\(35\\:0\\)\\: Invalid abbreviation \\# 4 defined for record.*");

}

} // end of anonymous namespace.

« no previous file with comments | « lib/Bitcode/NaCl/Reader/NaClBitstreamReader.cpp ('k') | unittests/Bitcode/NaClObjDumpTest.cpp » ('j') | no next file with comments »