Use colorfilter instead of imagefilter when possible

Use colorfilter instead of imagefilter when possible

needs https://codereview.chromium.org/1115713003 to land first in chrome

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/dbc3cefb0b624808ddb86d444e6103f216e12fa5

[reed1, 2015-04-28 14:08:25]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-04-28 14:08:37]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/986353002/20001

[commit-bot: I haz the power, 2015-04-28 14:16:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-28 14:16:17]

Dry run: Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia
(JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)

[reed1, 2015-04-29 16:47:51]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-04-29 16:48:06]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/986353002/40001

[commit-bot: I haz the power, 2015-04-29 16:51:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-29 16:51:15]

Dry run: This issue passed the CQ dry run.

[reed1, 2015-04-29 18:10:46]

reed@google.com changed reviewers:
+ robertphillips@google.com, senorblanco@google.com

[reed1, 2015-04-29 18:10:47]

an old CL revived, now that I *think* I fixed the PDF snag that we hit before.

ptal

[robertphillips, 2015-04-29 18:50:05]

lgtm + dox requests

https://codereview.chromium.org/986353002/diff/40001/src/core/SkCanvas.cpp
File src/core/SkCanvas.cpp (right):

https://codereview.chromium.org/986353002/diff/40001/src/core/SkCanvas.cpp#ne...
src/core/SkCanvas.cpp:330: 
imagefilter -> imagefilter that is a colorfilter ?

https://codereview.chromium.org/986353002/diff/40001/src/core/SkCanvas.cpp#ne...
src/core/SkCanvas.cpp:426: private:
fLazyPaintPerNext needs a better name (or a comment).

[reed1, 2015-04-29 19:05:37]

https://codereview.chromium.org/986353002/diff/40001/src/core/SkCanvas.cpp
File src/core/SkCanvas.cpp (right):

https://codereview.chromium.org/986353002/diff/40001/src/core/SkCanvas.cpp#ne...
src/core/SkCanvas.cpp:330: 
On 2015/04/29 18:50:05, robertphillips wrote:
> imagefilter -> imagefilter that is a colorfilter ?

Done.

https://codereview.chromium.org/986353002/diff/40001/src/core/SkCanvas.cpp#ne...
src/core/SkCanvas.cpp:426: private:
On 2015/04/29 18:50:05, robertphillips wrote:
> fLazyPaintPerNext needs a better name (or a comment).

Done.

[reed1, 2015-04-29 19:15:04]

The CQ bit was checked by reed@google.com

[reed1, 2015-04-29 19:15:05]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/986353002/#ps60001 (title:
"update dox")

[commit-bot: I haz the power, 2015-04-29 19:15:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/986353002/60001

[commit-bot: I haz the power, 2015-04-29 19:19:00]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/dbc3cefb0b624808ddb86d444e6103f216e12fa5