Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(594)

Issue 1115713003: add SK_SUPPORT_LEGACY_IMAGEFILTER_TO_COLORFILTER to guard skia change (Closed)

Created:
5 years, 7 months ago by reed1
Modified:
5 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

add SK_SUPPORT_LEGACY_IMAGEFILTER_TO_COLORFILTER to guard skia change in support of https://codereview.chromium.org/986353002/ BUG= Committed: https://crrev.com/a1d5d5f850a0f6fea46b92ee8abdd6efab201f5f Cr-Commit-Position: refs/heads/master@{#327537}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M skia/config/SkUserConfig.h View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1115713003/1
5 years, 7 months ago (2015-04-29 16:47:13 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-04-29 18:38:50 UTC) #5
reed1
ptal
5 years, 7 months ago (2015-04-29 18:59:07 UTC) #6
f(malita)
lgtm
5 years, 7 months ago (2015-04-29 19:03:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1115713003/1
5 years, 7 months ago (2015-04-29 19:04:32 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-29 19:11:00 UTC) #10
commit-bot: I haz the power
5 years, 7 months ago (2015-04-29 19:12:03 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a1d5d5f850a0f6fea46b92ee8abdd6efab201f5f
Cr-Commit-Position: refs/heads/master@{#327537}

Powered by Google App Engine
This is Rietveld 408576698