Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 986113004: Oilpan: avoid disabling GC plugin checks over Node. (Closed)

Created:
5 years, 9 months ago by sof
Modified:
5 years, 9 months ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, sof, eae+blinkwatch, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Oilpan: avoid disabling GC plugin checks over Node. With the GC plugin now recognizing GC_PLUGIN_IGNORE() on "operator new" overrides, move down Node's annotation. R=haraken BUG=443854 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191543

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M Source/core/dom/Node.h View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
sof
please take a look.
5 years, 9 months ago (2015-03-09 10:25:02 UTC) #2
haraken
LGTM
5 years, 9 months ago (2015-03-09 10:48:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/986113004/1
5 years, 9 months ago (2015-03-09 13:10:05 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-09 13:12:52 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191543

Powered by Google App Engine
This is Rietveld 408576698