Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(530)

Unified Diff: Source/core/dom/Node.h

Issue 986113004: Oilpan: avoid disabling GC plugin checks over Node. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/dom/Node.h
diff --git a/Source/core/dom/Node.h b/Source/core/dom/Node.h
index 317b504403792ed1bed12fcbf51a9604e395a009..db3ab18d1d859e6a8beedcb2a91a54819997d1ef 100644
--- a/Source/core/dom/Node.h
+++ b/Source/core/dom/Node.h
@@ -123,7 +123,7 @@ WILL_HAVE_ALL_INSTANCES_ON_SAME_GC_HEAP(Node);
#define NODE_BASE_CLASSES public EventTarget, public TreeShared<Node>
#endif
-class GC_PLUGIN_IGNORE("crbug.com/443854") Node : NODE_BASE_CLASSES {
+class Node : NODE_BASE_CLASSES {
DEFINE_EVENT_TARGET_REFCOUNTING_WILL_BE_REMOVED(TreeShared<Node>);
DEFINE_WRAPPERTYPEINFO();
friend class TreeScope;
@@ -167,6 +167,8 @@ public:
// static type dispatching of typed heap for Nodes. We override GarbageCollected<>'s operator new here, to put
// Node descendants into typed heap for Nodes. <http://crbug.com/443854>
using GarbageCollectedBase = EventTarget;
+
+ GC_PLUGIN_IGNORE("crbug.com/443854")
void* operator new(size_t size) { return Heap::allocate<Node>(size); }
#else // !ENABLE(OILPAN)
// All Nodes are placed in their own heap partition for security.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698