Issue 98603012: Revert of Encrypt all stored cookies on selected operating systems. - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(1221)

My Issues | Starred Open | Closed | All

Issue 98603012: Revert of Encrypt all stored cookies on selected operating systems. (Closed)

Created:
7 years ago by bcwhite

Modified:
7 years ago

Reviewers:
Jói, erikwright (departed), bcwhite1, jam, benm (inactive), rpetterson, Scott Hess - ex-Googler, szym

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, cbentzel+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Revert of https://codereview.chromium.org/24734007/ Reason for revert: buildbot failure in Chromium Memory FYI on Linux Tests (valgrind)(1) TBR=erikwright@chromium.org,shess@chromium.org,rlp@chromium.org,benm@chromium.org,jam@chromium.org,joi@chromium.org,bcwhite@google.com NOTREECHECKS=true NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=240709

Patch Set 1 #

Created: 7 years ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+68 lines, -320 lines)			Patch
	M	android_webview/native/cookie_manager.cc	View		2 chunks	+1 line, -3 lines	0 comments	Download
	M	chrome/browser/profiles/profile_impl_io_data.cc	View		5 chunks	+3 lines, -44 lines	0 comments	Download
	M	chrome/browser/safe_browsing/safe_browsing_service.cc	View		2 chunks	+1 line, -3 lines	0 comments	Download
	M	content/browser/net/sqlite_persistent_cookie_store.h	View		2 chunks	+1 line, -3 lines	0 comments	Download
	M	content/browser/net/sqlite_persistent_cookie_store.cc	View		16 chunks	+35 lines, -94 lines	0 comments	Download
	M	content/browser/net/sqlite_persistent_cookie_store_perftest.cc	View		3 chunks	+2 lines, -5 lines	0 comments	Download
	M	content/browser/net/sqlite_persistent_cookie_store_unittest.cc	View		20 chunks	+23 lines, -141 lines	0 comments	Download
	D	content/public/browser/cookie_crypto_delegate.h	View		1 chunk	+0 lines, -22 lines	0 comments	Download
	M	content/public/browser/cookie_store_factory.h	View		2 chunks	+2 lines, -5 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

bcwhite

Created Revert of Encrypt all stored cookies on selected operating systems.

7 years ago (2013-12-13 18:55:38 UTC) #1

commit-bot: I haz the power

No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...

7 years ago (2013-12-13 18:56:00 UTC) #2

Scott Hess - ex-Googler

On 2013/12/13 18:56:00, I haz the power (commit-bot) wrote: > No LGTM from a valid ...

7 years ago (2013-12-13 18:58:36 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bcwhite@chromium.org/98603012/1

7 years ago (2013-12-13 19:01:50 UTC) #5

Message was sent while issue was closed.

Change committed as 240709

Expand Messages | Collapse Messages

Powered by Google App Engine

This is Rietveld 408576698