Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Unified Diff: content/browser/browser_child_process_host_impl.h

Issue 98603007: Launches a privileged utility process. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Cleans up ChildProcessLauncher implementations. Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/browser_child_process_host_impl.h
diff --git a/content/browser/browser_child_process_host_impl.h b/content/browser/browser_child_process_host_impl.h
index 6345595a14e275790c96c67c0fec7456ebf726e0..aa8d4f8ad5039b128850a8904f953b3d9acc88b2 100644
--- a/content/browser/browser_child_process_host_impl.h
+++ b/content/browser/browser_child_process_host_impl.h
@@ -42,9 +42,11 @@ class CONTENT_EXPORT BrowserChildProcessHostImpl
// BrowserChildProcessHost implementation:
virtual bool Send(IPC::Message* message) OVERRIDE;
+
virtual void Launch(
#if defined(OS_WIN)
SandboxedProcessLauncherDelegate* delegate,
+ bool launch_elevated,
#elif defined(OS_POSIX)
bool use_zygote,
const base::EnvironmentMap& environ,
@@ -59,7 +61,7 @@ class CONTENT_EXPORT BrowserChildProcessHostImpl
// Returns the handle of the child process. This can be called only after
// OnProcessLaunched is called or it will be invalid and may crash.
- base::ProcessHandle GetHandle() const;
+ virtual base::ProcessHandle GetHandle() const;
jam 2014/01/30 21:41:03 since this is part of ChildProcessHostDelegate, dr
Drew Haven 2014/01/31 20:00:12 Done.
// Removes this host from the host list. Calls ChildProcessHost::ForceShutdown
void ForceShutdown();
@@ -98,6 +100,7 @@ class CONTENT_EXPORT BrowserChildProcessHostImpl
// ChildProcessLauncher::Client implementation.
virtual void OnProcessLaunched() OVERRIDE;
+ virtual void OnProcessLaunchFailed() OVERRIDE;
#if defined(OS_WIN)
void DeleteProcessWaitableEvent(base::WaitableEvent* event);

Powered by Google App Engine
This is Rietveld 408576698