Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(620)

Unified Diff: content/browser/browser_child_process_host_impl.cc

Issue 98603007: Launches a privileged utility process. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Cleans up ChildProcessLauncher implementations. Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/browser_child_process_host_impl.cc
diff --git a/content/browser/browser_child_process_host_impl.cc b/content/browser/browser_child_process_host_impl.cc
index 8e6bde3b0abb07daf0e2c09253c36dfce86b38e8..0ecc06b12d18b335296824d9522cd684a4758da4 100644
--- a/content/browser/browser_child_process_host_impl.cc
+++ b/content/browser/browser_child_process_host_impl.cc
@@ -131,6 +131,7 @@ void BrowserChildProcessHostImpl::TerminateAll() {
void BrowserChildProcessHostImpl::Launch(
#if defined(OS_WIN)
SandboxedProcessLauncherDelegate* delegate,
+ bool launch_elevated,
#elif defined(OS_POSIX)
bool use_zygote,
const base::EnvironmentMap& environ,
@@ -163,6 +164,7 @@ void BrowserChildProcessHostImpl::Launch(
child_process_.reset(new ChildProcessLauncher(
#if defined(OS_WIN)
delegate,
+ launch_elevated,
#elif defined(OS_POSIX)
use_zygote,
environ,
@@ -313,6 +315,11 @@ bool BrowserChildProcessHostImpl::Send(IPC::Message* message) {
return child_process_host_->Send(message);
}
+void BrowserChildProcessHostImpl::OnProcessLaunchFailed() {
+ delegate_->OnProcessLaunchFailed();
jam 2014/01/30 21:41:03 nit: two space indent
Drew Haven 2014/01/31 20:00:12 Done.
+ delete delegate_; // Will delete us
+}
+
void BrowserChildProcessHostImpl::OnProcessLaunched() {
base::ProcessHandle handle = child_process_->GetHandle();
if (!handle) {

Powered by Google App Engine
This is Rietveld 408576698