Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9860045: Address remaining nits for r129104. (Closed)

Created:
8 years, 9 months ago by Sergey Ulanov
Modified:
8 years, 9 months ago
Reviewers:
simonmorris, Wez
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Address remaining nits for r129104. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=129371

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Total comments: 3

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -21 lines) Patch
M remoting/client/plugin/chromoting_instance.h View 1 1 chunk +1 line, -1 line 0 comments Download
M remoting/client/plugin/chromoting_instance.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/client/plugin/pepper_view.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/host/chromoting_host.cc View 1 1 chunk +5 lines, -5 lines 0 comments Download
M remoting/protocol/errors.h View 1 1 chunk +1 line, -1 line 0 comments Download
M remoting/protocol/jingle_session.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/protocol/jingle_session_manager.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/protocol/session_manager.h View 1 1 chunk +1 line, -1 line 0 comments Download
M remoting/webapp/_locales/en/messages.json View 1 1 chunk +1 line, -1 line 0 comments Download
M remoting/webapp/client_screen.js View 1 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/webapp/client_session.js View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M remoting/webapp/remoting.js View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
Sergey Ulanov
http://codereview.chromium.org/9836062/
8 years, 9 months ago (2012-03-27 18:01:48 UTC) #1
Wez
http://codereview.chromium.org/9860045/diff/1/remoting/protocol/jingle_session_manager.cc File remoting/protocol/jingle_session_manager.cc (right): http://codereview.chromium.org/9860045/diff/1/remoting/protocol/jingle_session_manager.cc#newcode161 remoting/protocol/jingle_session_manager.cc:161: error = HOST_IS_DISABLED; I think HOST_IS_DISABLED needs the name ...
8 years, 9 months ago (2012-03-27 20:03:00 UTC) #2
Sergey Ulanov
http://codereview.chromium.org/9860045/diff/1/remoting/protocol/jingle_session_manager.cc File remoting/protocol/jingle_session_manager.cc (right): http://codereview.chromium.org/9860045/diff/1/remoting/protocol/jingle_session_manager.cc#newcode161 remoting/protocol/jingle_session_manager.cc:161: error = HOST_IS_DISABLED; On 2012/03/27 20:03:01, Wez wrote: > ...
8 years, 9 months ago (2012-03-27 21:28:06 UTC) #3
Wez
lgtm
8 years, 9 months ago (2012-03-27 21:43:51 UTC) #4
simonmorris
http://codereview.chromium.org/9860045/diff/9013/remoting/webapp/client_session.js File remoting/webapp/client_session.js (right): http://codereview.chromium.org/9860045/diff/9013/remoting/webapp/client_session.js#newcode92 remoting/webapp/client_session.js:92: HOST_OVERLOAD: 5, The comma in this line breaks JSCompiler ...
8 years, 9 months ago (2012-03-27 22:03:01 UTC) #5
Sergey Ulanov
http://codereview.chromium.org/9860045/diff/9013/remoting/webapp/client_session.js File remoting/webapp/client_session.js (right): http://codereview.chromium.org/9860045/diff/9013/remoting/webapp/client_session.js#newcode92 remoting/webapp/client_session.js:92: HOST_OVERLOAD: 5, On 2012/03/27 22:03:02, simonmorris wrote: > The ...
8 years, 9 months ago (2012-03-27 22:08:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/9860045/11013
8 years, 9 months ago (2012-03-27 22:49:53 UTC) #7
commit-bot: I haz the power
Can't apply patch for file remoting/webapp/client_session.js. While running patch -p1 --forward --force; patching file remoting/webapp/client_session.js ...
8 years, 9 months ago (2012-03-27 22:49:57 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/9860045/5015
8 years, 9 months ago (2012-03-27 23:22:06 UTC) #9
commit-bot: I haz the power
Try job failure for 9860045-5015 (retry) on win_rel for step "browser_tests". It's a second try, ...
8 years, 9 months ago (2012-03-28 02:16:03 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/9860045/5015
8 years, 9 months ago (2012-03-28 03:02:13 UTC) #11
commit-bot: I haz the power
8 years, 9 months ago (2012-03-28 04:38:54 UTC) #12 
Change committed as 129371

Powered by Google App Engine
This is Rietveld 408576698