Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1665)

Unified Diff: remoting/host/chromoting_host.cc

Issue 9860045: Address remaining nits for r129104. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/client/plugin/pepper_view.cc ('k') | remoting/protocol/errors.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/host/chromoting_host.cc
diff --git a/remoting/host/chromoting_host.cc b/remoting/host/chromoting_host.cc
index 109a306c17e5979f1fabda82e303bf70c5953e4a..d594642573f9a344f5f98b268961332547d5ca83 100644
--- a/remoting/host/chromoting_host.cc
+++ b/remoting/host/chromoting_host.cc
@@ -280,14 +280,14 @@ void ChromotingHost::OnIncomingSession(
}
if (login_backoff_.ShouldRejectRequest()) {
- *response = protocol::SessionManager::DISABLED;
+ *response = protocol::SessionManager::OVERLOAD;
return;
}
- // Backoff incoming connections until the new connection is
- // authenticated. Is is neccessary to prevent the attack when
- // multiple connections are initiated at the same time and all of
- // them try to authenticate simultaneously.
+ // We treat each incoming connection as a failure to authenticate,
+ // and clear the backoff when a connection successfully
+ // authenticates. This allows the backoff to protect from parallel
+ // connection attempts as well as sequential ones.
login_backoff_.InformOfRequest(false);
protocol::SessionConfig config;
« no previous file with comments | « remoting/client/plugin/pepper_view.cc ('k') | remoting/protocol/errors.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698