Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 98583009: Back out r240455 on the trunk. It caused http://crbug.com/328776. (Closed)

Created:
7 years ago by Mark Mentovai
Modified:
7 years ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews
Visibility:
Public.

Description

Back out r240455 on the trunk. It caused http://crbug.com/328776. > [Mac] Always animate extension popup window size changes. > > Something about the new window animation changed in 10.9 in a way that's > difficult to detect. > > BUG=307912 > > Review URL: https://codereview.chromium.org/111493003 BUG=307912, 328776 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=240946

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -10 lines) Patch
M trunk/src/chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm View 1 chunk +13 lines, -10 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Mark Mentovai
7 years ago (2013-12-16 18:50:01 UTC) #1
Mark Mentovai
Committed patchset #1 manually as r240946.
7 years ago (2013-12-16 18:50:19 UTC) #2
szym
On 2013/12/16 18:50:19, Mark Mentovai wrote: > Committed patchset #1 manually as r240946. Suspecting this ...
7 years ago (2013-12-16 20:20:37 UTC) #3
Mark Mentovai
Doubt it. And it passed on the next run. To unsubscribe from this group and ...
7 years ago (2013-12-16 20:49:52 UTC) #4
szym
7 years ago (2013-12-16 20:50:38 UTC) #5
Message was sent while issue was closed.
On 2013/12/16 20:49:52, Mark Mentovai wrote:
> Doubt it. And it passed on the next run.
> 
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

Yeah, it was a flake. Not reverting.

Powered by Google App Engine
This is Rietveld 408576698