[Mac] Always animate extension popup window size changes.

[Mac] Always animate extension popup window size changes.

Something about the new window animation changed in 10.9 in a way that's
difficult to detect.

BUG=307912
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=240455

[Mark Mentovai, 2013-12-11 20:53:17]

There’s a definite behavior change here: now, any resize will animate. But maybe
that’s OK, or even desirable, for extension popups.

[Robert Sesek, 2013-12-11 21:27:17]

On 2013/12/11 20:53:17, Mark Mentovai wrote:
> There’s a definite behavior change here: now, any resize will animate. But
maybe
> that’s OK, or even desirable, for extension popups.

The only time I can remember seeing an open extension popup change size is when
it's being janky about its own content size and thus the window frame changes,
too. I think this behavior change may make that jank worse :/.

[Mark Mentovai, 2013-12-11 21:28:54]

Suggestions for alternatives?

[Robert Sesek, 2013-12-11 21:44:16]

On 2013/12/11 21:28:54, Mark Mentovai wrote:
> Suggestions for alternatives?

No idea if this will work, but it should allow you to query the animation state:

if (!animation_) {
  [CATransaction begin];
  [CATransaction setCompletionBlock:^{
      animation_ = nil;
      [window setAnimations:nil];  // May not be necessary.
  }];
  animation_ = [CABasicAnimation animationWithKeyPath:@"frame"];
  [animation setFromValue:[NSValue valueWithRect:[window frame]];
  [animation setToValue:[NSValue valueWithRect:frame]
  [animation setDuration:0.25];
  [window setAnimations:@{ @"frame" : animation }];
  [CATransaction end];
}

[Mark Mentovai, 2013-12-11 22:16:22]

That’s just as bad. It’s not our own animation that I’m having a hard time
detecting. The problem seems to be that [window setFrame:frame display:YES] is
animating in a way that we can’t detect or influence.

[Robert Sesek, 2013-12-11 22:20:09]

On 2013/12/11 22:16:22, Mark Mentovai wrote:
> That’s just as bad. It’s not our own animation that I’m having a hard time
> detecting. The problem seems to be that [window setFrame:frame display:YES] is
> animating in a way that we can’t detect or influence.

Yeah, that's yuck. OK, let's live with the behavior change then and see if
there's any fallout. But as I mentioned above, I haven't used an extension that
actively changes its own size deliberately, so hopefully this is an edge case.

LGTM.

[commit-bot: I haz the power, 2013-12-12 20:08:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mark@chromium.org/111493003/1

[commit-bot: I haz the power, 2013-12-12 22:53:02]

Change committed as 240455