Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Issue 98573004: Android: relands r237947, split golden content from jni_generator_tests. (Closed)

Created:
7 years ago by bulach
Modified:
7 years ago
Reviewers:
Sami
CC:
chromium-reviews, erikwright+watch_chromium.org
Visibility:
Public.

Description

Android: relands r237947, split golden content from jni_generator_tests. Rather than intermix the generated golden files with the test script, extract in separate files. Also, if "REBASELINE" environment variable is set, it'll re-generate the golden scripts, to it's much simpler to do changes in the generator itself. Note: there are NO functional changes in the generator itself, only in the tests. Previous attempt failed with mismatch copyright message due to the precommit hook. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238084

Patch Set 1 : Original patch #

Patch Set 2 : Fixes test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1394 lines, -1385 lines) Patch
M base/android/jni_generator/jni_generator_tests.py View 1 12 chunks +39 lines, -1385 lines 0 comments Download
A base/android/jni_generator/testCalledByNatives.golden View 1 chunk +486 lines, -0 lines 0 comments Download
A base/android/jni_generator/testFromJavaP.golden View 1 chunk +255 lines, -0 lines 0 comments Download
A base/android/jni_generator/testFromJavaPGenerics.golden View 1 chunk +63 lines, -0 lines 0 comments Download
A base/android/jni_generator/testInnerClassNatives.golden View 1 chunk +58 lines, -0 lines 0 comments Download
A base/android/jni_generator/testInnerClassNativesBothInnerAndOuter.golden View 1 chunk +77 lines, -0 lines 0 comments Download
A base/android/jni_generator/testInnerClassNativesMultiple.golden View 1 chunk +78 lines, -0 lines 0 comments Download
A base/android/jni_generator/testJarJarRemapping.golden View 1 chunk +59 lines, -0 lines 0 comments Download
A base/android/jni_generator/testNatives.golden View 1 chunk +216 lines, -0 lines 0 comments Download
A base/android/jni_generator/testNativesLong.golden View 1 chunk +63 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
bulach
this got reverted here: https://codereview.chromium.org/97313002 there's a presubmit hook that triggers and changes the copyright ...
7 years ago (2013-12-02 09:45:59 UTC) #1
Sami
On 2013/12/02 09:45:59, bulach wrote: > there's a presubmit hook that triggers and changes the ...
7 years ago (2013-12-02 10:20:30 UTC) #2
bulach
thanks sami! there are quite a few files with the old copyright notice, I think ...
7 years ago (2013-12-02 10:52:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/98573004/60001
7 years ago (2013-12-02 10:52:40 UTC) #4
commit-bot: I haz the power
7 years ago (2013-12-02 13:22:17 UTC) #5
Message was sent while issue was closed.
Change committed as 238084

Powered by Google App Engine
This is Rietveld 408576698