Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 97313002: Revert 237947 "Android: split golden content from jni_generator_..." (Closed)

Created:
7 years ago by scottmg
Modified:
7 years ago
Reviewers:
bulach
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 237947 "Android: split golden content from jni_generator_..." Broke Android clobber: FAILED: cd ../../base/android/jni_generator; python jni_generator_tests.py .__main__.TestGenerator.testCalledByNatives *** --- *************** *** 1,4 **** ! // Copyright 2013 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. --- 1,4 ---- ! // Copyright (c) 2012 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. Generated ================================================================================ // Copyright (c) 2012 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. ... ... ... } #endif // org_chromium_TestJni_JNI ================================================================================ Run with: REBASELINE=1 jni_generator_tests.py to regenerate the data files. ninja: build stopped: subcommand failed. > Android: split golden content from jni_generator_tests. > > Rather than intermix the generated golden files with the test script, > extract in separate files. > Also, if "REBASELINE" environment variable is set, it'll re-generate the > golden scripts, to it's much simpler to do changes in the generator itself. > Note: there are NO functional changes in the generator itself, only in the tests. > > BUG= > > Review URL: https://codereview.chromium.org/96523004 TBR=bulach@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=237956

Patch Set 1 #

Messages

Total messages: 3 (0 generated)
scottmg
7 years ago (2013-11-30 00:05:14 UTC) #1
scottmg
Committed patchset #1 manually as r237956.
7 years ago (2013-11-30 00:05:21 UTC) #2
bulach
7 years ago (2013-12-02 11:03:26 UTC) #3
Message was sent while issue was closed.
gargh! :) thanks for reverting, and sorry about the breakage. fixed and
relanding here: https://codereview.chromium.org/98573004/

Powered by Google App Engine
This is Rietveld 408576698