Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 985703003: Revert of Revert of DevTools: Remove pageAgent() call from DebuggerModel (Closed)

Created:
5 years, 9 months ago by sergeyv
Modified:
5 years, 9 months ago
Reviewers:
dgozman, lushnikov, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Revert of DevTools: Remove pageAgent() call from DebuggerModel (patchset #1 id:1 of https://codereview.chromium.org/982783002/) Reason for revert: The cause of problem was fixed in https://codereview.chromium.org/982863002 Reapplying original patch Original issue's description: > Revert of DevTools: Remove pageAgent() call from DebuggerModel (patchset #2 id:20001 of https://codereview.chromium.org/975453002/) > > Reason for revert: > This breaks F8 shortcut. @see crbug.com/464342 > > Original issue's description: > > DevTools: Remove pageAgent() call from DebuggerModel > > > > BUG=462924 > > > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191195 > > TBR=pfeldman@chromium.org,dgozman@chromium.org,sergeyv@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=462924 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191358 TBR=pfeldman@chromium.org,dgozman@chromium.org,lushnikov@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=462924 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191424

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -70 lines) Patch
M Source/devtools/devtools.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M Source/devtools/front_end/main/Main.js View 1 chunk +1 line, -0 lines 0 comments Download
A Source/devtools/front_end/main/OverlayController.js View 1 chunk +27 lines, -0 lines 0 comments Download
M Source/devtools/front_end/main/module.json View 1 chunk +1 line, -0 lines 0 comments Download
M Source/devtools/front_end/sdk/DebuggerModel.js View 3 chunks +5 lines, -70 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
sergeyv
Created Revert of Revert of DevTools: Remove pageAgent() call from DebuggerModel
5 years, 9 months ago (2015-03-06 11:25:00 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/985703003/1
5 years, 9 months ago (2015-03-06 11:25:40 UTC) #2
commit-bot: I haz the power
5 years, 9 months ago (2015-03-06 11:26:20 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191424

Powered by Google App Engine
This is Rietveld 408576698