Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 982863002: Devtools: [SourcesPanel] register shortcuts via ActionRegistry (Closed)

Created:
5 years, 9 months ago by sergeyv
Modified:
5 years, 9 months ago
Reviewers:
pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Devtools: [SourcesPanel] register shortcuts via ActionRegistry BUG=464342 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191422

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+183 lines, -64 lines) Patch
M Source/devtools/front_end/components/ShortcutsScreen.js View 2 chunks +5 lines, -30 lines 0 comments Download
M Source/devtools/front_end/sources/SourcesPanel.js View 6 chunks +97 lines, -34 lines 2 comments Download
M Source/devtools/front_end/sources/module.json View 1 chunk +81 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
sergeyv
5 years, 9 months ago (2015-03-05 17:29:01 UTC) #2
pfeldman
lgtm % nits https://codereview.chromium.org/982863002/diff/1/Source/devtools/front_end/sources/SourcesPanel.js File Source/devtools/front_end/sources/SourcesPanel.js (left): https://codereview.chromium.org/982863002/diff/1/Source/devtools/front_end/sources/SourcesPanel.js#oldcode727 Source/devtools/front_end/sources/SourcesPanel.js:727: if (Runtime.experiments.isEnabled("stepIntoAsync")) { This is missing.
5 years, 9 months ago (2015-03-05 20:09:24 UTC) #3
sergeyv
https://codereview.chromium.org/982863002/diff/1/Source/devtools/front_end/sources/SourcesPanel.js File Source/devtools/front_end/sources/SourcesPanel.js (left): https://codereview.chromium.org/982863002/diff/1/Source/devtools/front_end/sources/SourcesPanel.js#oldcode727 Source/devtools/front_end/sources/SourcesPanel.js:727: if (Runtime.experiments.isEnabled("stepIntoAsync")) { On 2015/03/05 20:09:23, pfeldman wrote: > ...
5 years, 9 months ago (2015-03-06 09:33:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/982863002/1
5 years, 9 months ago (2015-03-06 09:42:36 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-06 11:00:00 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191422

Powered by Google App Engine
This is Rietveld 408576698