content/browser/service_worker/service_worker_version.h - Issue 985663002: Implement ServiceWorkerRegistration related DevTools events [2/2 chromium]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_version.h

Issue 985663002: Implement ServiceWorkerRegistration related DevTools events [2/2 chromium] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: incorporated pfeldman's comment Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/service_worker/service_worker_context_unittest.cc ('K') | « content/browser/service_worker/service_worker_internals_ui.cc ('k') | content/browser/service_worker/service_worker_version.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_version.h

diff --git a/content/browser/service_worker/service_worker_version.h b/content/browser/service_worker/service_worker_version.h

index 954aecc707989a139ec53d04a3f6f5b2dd33105a..86d6635df100526702cebe9ab363cf6d8600cb00 100644

--- a/content/browser/service_worker/service_worker_version.h

+++ b/content/browser/service_worker/service_worker_version.h

@@ -92,8 +92,7 @@ class CONTENT_EXPORT ServiceWorkerVersion

class Listener {

public:

- virtual void OnWorkerStarted(ServiceWorkerVersion* version) {}

- virtual void OnWorkerStopped(ServiceWorkerVersion* version) {}

+ virtual void OnRunningStateChanged(ServiceWorkerVersion* version) {}

virtual void OnVersionStateChanged(ServiceWorkerVersion* version) {}

virtual void OnErrorReported(ServiceWorkerVersion* version,

const base::string16& error_message,

@@ -320,7 +319,9 @@ class CONTENT_EXPORT ServiceWorkerVersion

// EmbeddedWorkerInstance::Listener overrides:

void OnScriptLoaded() override;

+ void OnStarting() override;

void OnStarted() override;

+ void OnStopping() override;

void OnStopped(EmbeddedWorkerInstance::Status old_status) override;

void OnReportException(const base::string16& error_message,

int line_number,