content/browser/service_worker/service_worker_context_unittest.cc - Issue 985663002: Implement ServiceWorkerRegistration related DevTools events [2/2 chromium]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_context_unittest.cc

Issue 985663002: Implement ServiceWorkerRegistration related DevTools events [2/2 chromium] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: incorporated pfeldman's comment Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_context_observer.h ('k') | content/browser/service_worker/service_worker_info.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_context_unittest.cc

diff --git a/content/browser/service_worker/service_worker_context_unittest.cc b/content/browser/service_worker/service_worker_context_unittest.cc

index 6554279524cb077a9fbd2152a85ddb22e4587778..f97190e0786a5d9ae3b9c968b2da4429510b4457 100644

--- a/content/browser/service_worker/service_worker_context_unittest.cc

+++ b/content/browser/service_worker/service_worker_context_unittest.cc

@@ -131,7 +131,8 @@ class ServiceWorkerContextTest : public ServiceWorkerContextObserver,

void TearDown() override { helper_.reset(); }

// ServiceWorkerContextObserver overrides.

- void OnRegistrationStored(const GURL& pattern) override {

+ void OnRegistrationStored(int64 registration_id,

Kunihiko Sakamoto 2015/03/10 05:38:08 Can you update existing tests to verify that regis

horo 2015/03/11 00:32:33 Done.

+ const GURL& pattern) override {

NotificationLog log;

log.type = REGISTRATION_STORED;

log.pattern = pattern;