content/browser/devtools/render_frame_devtools_agent_host.cc - Issue 985663002: Implement ServiceWorkerRegistration related DevTools events [2/2 chromium]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/devtools/render_frame_devtools_agent_host.cc

Issue 985663002: Implement ServiceWorkerRegistration related DevTools events [2/2 chromium] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: incorporated pfeldman's comment Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/devtools/protocol/service_worker_handler.cc ('k') | content/browser/resources/service_worker/serviceworker_internals.js » ('j') | content/browser/service_worker/service_worker_context_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/devtools/render_frame_devtools_agent_host.cc

diff --git a/content/browser/devtools/render_frame_devtools_agent_host.cc b/content/browser/devtools/render_frame_devtools_agent_host.cc

index 81cbe7e9b4ae0ef0be01774ef0afe476e02cb4a3..acc2a2736de427e9a98ac0ad3156087bda2f83c6 100644

--- a/content/browser/devtools/render_frame_devtools_agent_host.cc

+++ b/content/browser/devtools/render_frame_devtools_agent_host.cc

@@ -437,6 +437,7 @@ void RenderFrameDevToolsAgentHost::SetRenderFrameHost(RenderFrameHost* rfh) {

input_handler_->SetRenderViewHost(rvh);

network_handler_->SetRenderViewHost(rvh);

page_handler_->SetRenderViewHost(rvh);

+ service_worker_handler_->SetRenderFrameHost(rfh);

registrar_.Add(

this,

@@ -457,6 +458,7 @@ void RenderFrameDevToolsAgentHost::ClearRenderFrameHost() {

input_handler_->SetRenderViewHost(nullptr);

network_handler_->SetRenderViewHost(nullptr);

page_handler_->SetRenderViewHost(nullptr);

+ service_worker_handler_->SetRenderFrameHost(nullptr);

}

void RenderFrameDevToolsAgentHost::DisconnectWebContents() {