Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1126)

Issue 985633003: Service Worker: Clients.openWindow() should allow opening x-origin URLs (Closed)

Created:
5 years, 9 months ago by jungkees
Modified:
5 years, 9 months ago
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, tzik, serviceworker-reviews, nhiroki, kinuko+serviceworker, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Service Worker: Clients.openWindow() should allow opening x-origin URLs Clients.openWindow(url) with a cross-origin url currently rejects with a SecurityError exception. As per spec: https://slightlyoff.github.io/ServiceWorker/spec/service_worker/index.html#clients-openwindow it should open a window and resolve with null. Checked the expected behavior with @jakearchibald. Corresponding content changes: https://codereview.chromium.org/984853003/ BUG=464680

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -10 lines) Patch
M LayoutTests/http/tests/serviceworker/chromium/clients-openwindow.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/chromium/resources/clients-openwindow.js View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerClients.cpp View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
jsbell
lgtm
5 years, 9 months ago (2015-03-06 16:59:42 UTC) #2
falken
Oops, you should coordinate with mlamouri who has patches up for this: https://codereview.chromium.org/980383004/ See also ...
5 years, 9 months ago (2015-03-06 17:02:09 UTC) #3
mlamouri (slow - plz ping)
not lgtm, we don't want openWindow() to be able to open urls like "file://" or ...
5 years, 9 months ago (2015-03-06 17:04:20 UTC) #4
jungkees
On 2015/03/06 17:04:20, Mounir Lamouri wrote: > not lgtm, we don't want openWindow() to be ...
5 years, 9 months ago (2015-03-09 05:51:49 UTC) #5
falken
On 2015/03/09 05:51:49, jungkees wrote: > On 2015/03/06 17:04:20, Mounir Lamouri wrote: > > not ...
5 years, 9 months ago (2015-03-09 06:31:05 UTC) #6
jungkees
5 years, 9 months ago (2015-03-09 07:31:01 UTC) #7
Message was sent while issue was closed.
On 2015/03/09 06:31:05, falken wrote:
> On 2015/03/09 05:51:49, jungkees wrote:
> > On 2015/03/06 17:04:20, Mounir Lamouri wrote:
>
> Yep please close this... apologies and thanks for taking on the bug!

Thanks for reviewing!

Powered by Google App Engine
This is Rietveld 408576698