Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(588)

Issue 985043002: Relax same-origin policy for ServiceWorker openWindow() in Blink. (Closed)

Created:
5 years, 9 months ago by mlamouri (slow - plz ping)
Modified:
5 years, 9 months ago
CC:
blink-reviews, falken, horo+watch_chromium.org, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, kinuko+serviceworker, michaeln, nhiroki, serviceworker-reviews, tzik
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Relax same-origin policy for ServiceWorker openWindow() in Blink. This is the Blink patch following the Chromium change: https://codereview.chromium.org/980383004 This CL also include the tests. BUG=457187 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191649

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -9 lines) Patch
M LayoutTests/http/tests/serviceworker/chromium/clients-openwindow.html View 1 2 chunks +11 lines, -3 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/chromium/resources/clients-openwindow.js View 1 2 chunks +39 lines, -4 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerClients.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
mlamouri (slow - plz ping)
Same as https://codereview.chromium.org/980383004 mkwst@, jochen@ and tsepez@ please have a look at the security implications. ...
5 years, 9 months ago (2015-03-06 15:46:58 UTC) #2
Mike West
LGTM.
5 years, 9 months ago (2015-03-06 15:59:53 UTC) #3
jochen (gone - plz use gerrit)
lgtm
5 years, 9 months ago (2015-03-09 15:30:34 UTC) #4
Tom Sepez
lgtm
5 years, 9 months ago (2015-03-09 16:59:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/985043002/1
5 years, 9 months ago (2015-03-09 20:01:51 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/51470)
5 years, 9 months ago (2015-03-10 04:26:29 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/985043002/20001
5 years, 9 months ago (2015-03-10 13:27:43 UTC) #12
commit-bot: I haz the power
5 years, 9 months ago (2015-03-10 18:48:50 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191649

Powered by Google App Engine
This is Rietveld 408576698