Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 985563002: Disable LauncherPageFocusTraversal browser test on all platforms. (Closed)

Created:
5 years, 9 months ago by Matt Giuca
Modified:
5 years, 9 months ago
Reviewers:
tapted, Dirk Pranke
CC:
chromium-reviews, calamity, benwells, Dirk Pranke
Base URL:
https://chromium.googlesource.com/chromium/src.git@ulan-disable-customlauncherpagefocustest
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable LauncherPageFocusTraversal browser test on all platforms. Was previously disabled on ChromeOS, but appears to be flaky across the board. BUG=463456 Committed: https://crrev.com/cc5a873aa82d7b56bdaf2f3160f1ceaca998f202 Cr-Commit-Position: refs/heads/master@{#319385}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -8 lines) Patch
M chrome/browser/apps/custom_launcher_page_browsertest_views.cc View 1 chunk +2 lines, -8 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Matt Giuca
5 years, 9 months ago (2015-03-06 00:22:59 UTC) #2
Dirk Pranke
lgtm :).
5 years, 9 months ago (2015-03-06 00:25:01 UTC) #4
tapted
lgtm yehhh it makes sense that focus traversal would flake in a non-interactive test
5 years, 9 months ago (2015-03-06 00:26:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/985563002/1
5 years, 9 months ago (2015-03-06 00:29:16 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-06 01:14:01 UTC) #9
commit-bot: I haz the power
5 years, 9 months ago (2015-03-06 01:14:56 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cc5a873aa82d7b56bdaf2f3160f1ceaca998f202
Cr-Commit-Position: refs/heads/master@{#319385}

Powered by Google App Engine
This is Rietveld 408576698