Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3082)

Unified Diff: chrome/browser/apps/custom_launcher_page_browsertest_views.cc

Issue 985563002: Disable LauncherPageFocusTraversal browser test on all platforms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ulan-disable-customlauncherpagefocustest
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/apps/custom_launcher_page_browsertest_views.cc
diff --git a/chrome/browser/apps/custom_launcher_page_browsertest_views.cc b/chrome/browser/apps/custom_launcher_page_browsertest_views.cc
index 00e34840152f687f989d7e66c37ed471b24543ae..485fe6dc4763df9e5d6d557028bdb9585e22b43b 100644
--- a/chrome/browser/apps/custom_launcher_page_browsertest_views.cc
+++ b/chrome/browser/apps/custom_launcher_page_browsertest_views.cc
@@ -387,16 +387,10 @@ IN_PROC_BROWSER_TEST_F(CustomLauncherPageBrowserTest, LauncherPageSetEnabled) {
EXPECT_TRUE(custom_page_view->visible());
}
-// Currently this fails on ChromeOS
+// Currently this is flaky.
// Disabled test http://crbug.com/463456
-#if defined(OS_CHROMEOS)
-#define MAYBE_LauncherPageFocusTraversal DISABLED_LauncherPageFocusTraversal
-#else
-#define MAYBE_LauncherPageFocusTraversal LauncherPageFocusTraversal
-#endif
-
IN_PROC_BROWSER_TEST_F(CustomLauncherPageBrowserTest,
- MAYBE_LauncherPageFocusTraversal) {
+ DISABLED_LauncherPageFocusTraversal) {
LoadAndLaunchPlatformApp(kCustomLauncherPagePath, "Launched");
app_list::AppListView* app_list_view = GetAppListView();
app_list::ContentsView* contents_view =
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698