Omnibox - Make Omnibox Extensions Ignore Stop() Calls Due to User Idleness

chrome/browser/autocomplete/autocomplete_controller.h

Index: chrome/browser/autocomplete/autocomplete_controller.h
diff --git a/chrome/browser/autocomplete/autocomplete_controller.h b/chrome/browser/autocomplete/autocomplete_controller.h
index 08b1164448c35fa355c0cf0182bdd303999db9df..334bbe12db43bd708cacd456dc5c9e3d227532c3 100644
--- a/chrome/browser/autocomplete/autocomplete_controller.h
+++ b/chrome/browser/autocomplete/autocomplete_controller.h
@@ -199,6 +199,11 @@ class AutocompleteController : public AutocompleteProviderListener {
   // Starts |stop_timer_|.
   void StartStopTimer();
 
+  // Helper function for Stop().  |user_inactivity_timer| means this call was
+  // triggered by a user's idleness, i.e., not an explicit user action.
+  void StopHelper(bool clear_result,
+                  bool user_inactivity_timer);

[Peter Kasting, 2015/03/05 23:27:28]

Nit: How about "due_to_user_inactivity" or "from_inactivity_timer" or something?
 I mostly want to convert this arg from just the name of a timer into a
descriptive reason.

(Also applies to AutocompleteProvider::Stop())

[Mark P, 2015/03/06 21:24:34]

Good suggestions.  Both are better than what I had.  I prefer the former, so I
revised this changelist to use it everywhere.

+
   AutocompleteControllerDelegate* delegate_;
 
   // A list of all providers.