Omnibox - Make Omnibox Extensions Ignore Stop() Calls Due to User Idleness

chrome/browser/autocomplete/autocomplete_controller.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_AUTOCOMPLETE_AUTOCOMPLETE_CONTROLLER_H_
 #define CHROME_BROWSER_AUTOCOMPLETE_AUTOCOMPLETE_CONTROLLER_H_
 
 #include "base/basictypes.h"
 #include "base/compiler_specific.h"
 #include "base/gtest_prod_util.h"
@@ skipping 181 matching lines @@
 
   // Updates |done_| to be accurate with respect to current providers' statuses.
   void CheckIfDone();
 
   // Starts |expire_timer_|.
   void StartExpireTimer();
 
   // Starts |stop_timer_|.
   void StartStopTimer();
 
+  // Helper function for Stop().  |user_inactivity_timer| means this call was
+  // triggered by a user's idleness, i.e., not an explicit user action.
+  void StopHelper(bool clear_result,
+                  bool user_inactivity_timer);

[Peter Kasting, 2015/03/05 23:27:28]

Nit: How about "due_to_user_inactivity" or "from_inactivity_timer" or something?
 I mostly want to convert this arg from just the name of a timer into a
descriptive reason.

(Also applies to AutocompleteProvider::Stop())

[Mark P, 2015/03/06 21:24:34]

Good suggestions.  Both are better than what I had.  I prefer the former, so I
revised this changelist to use it everywhere.

+
   AutocompleteControllerDelegate* delegate_;
 
   // A list of all providers.
   Providers providers_;
 
   HistoryURLProvider* history_url_provider_;
 
   KeywordProvider* keyword_provider_;
 
   SearchProvider* search_provider_;
@@ skipping 38 matching lines @@
   // Are we in Start()? This is used to avoid updating |result_| and sending
   // notifications until Start() has been invoked on all providers.
   bool in_start_;
 
   TemplateURLService* template_url_service_;
 
   DISALLOW_COPY_AND_ASSIGN(AutocompleteController);
 };
 
 #endif  // CHROME_BROWSER_AUTOCOMPLETE_AUTOCOMPLETE_CONTROLLER_H_