Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Issue 98543012: [CSS Blending] SVG overlapping elements within a group don't blend together. (Closed)

Created:
7 years ago by mitica
Modified:
6 years, 11 months ago
CC:
blink-reviews, krit, bemjb+rendering_chromium.org, zoltan1, eae+blinkwatch, leviw+renderwatch, f(malita), jchaffraix+rendering, pdr, Stephen Chennney, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

[CSS Blending] SVG overlapping elements within a group don't blend together. For a group of overlapping elements in an SVG, if mix-blend-mode is specified on the group, the intersection of any overlapping elements also incorrectly blends. This patch addresses the issue. The problem is similar to https://codereview.chromium.org/104663003/ BUG=229615 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164504

Patch Set 1 #

Total comments: 1

Patch Set 2 : Comment test description #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -0 lines) Patch
A LayoutTests/css3/compositing/svg-blend-overlapping-elements.html View 1 1 chunk +14 lines, -0 lines 0 comments Download
A LayoutTests/css3/compositing/svg-blend-overlapping-elements-expected.html View 1 1 chunk +14 lines, -0 lines 0 comments Download
M Source/core/rendering/svg/SVGRenderingContext.cpp View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
mitica
Hi Dirk, Stephen, Can you please have a look over this patch? Thanks!
7 years ago (2013-12-20 12:56:45 UTC) #1
Stephen Chennney
LGTM but please deal with the test case before submitting (or put up a follow ...
6 years, 11 months ago (2013-12-30 16:31:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mitica@adobe.com/98543012/70001
6 years, 11 months ago (2014-01-06 09:51:57 UTC) #3
commit-bot: I haz the power
6 years, 11 months ago (2014-01-06 11:27:24 UTC) #4
Message was sent while issue was closed.
Change committed as 164504

Powered by Google App Engine
This is Rietveld 408576698