Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 104663003: [CSS Blending] When applying mix-blend-mode on an element, (Closed)

Created:
7 years ago by mitica
Modified:
7 years ago
Reviewers:
Stephen Chennney
CC:
blink-reviews, bemjb+rendering_chromium.org, zoltan1, eae+blinkwatch, leviw+renderwatch, blink-layers+watch_chromium.org, jchaffraix+rendering
Visibility:
Public.

Description

[CSS Blending] When applying mix-blend-mode on an element, its contents and its children should blend as a whole with the backdrop. BUG=229615 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164026

Patch Set 1 #

Patch Set 2 : Fix that no longer breaks background blending #

Patch Set 3 : Rebase #

Patch Set 4 : Proper fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M LayoutTests/TestExpectations View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderLayer.cpp View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
mitica
Hi Stephen, please review this change. Thanks!
7 years ago (2013-12-09 12:16:48 UTC) #1
mitica
The first approach wasn't right, I'm working on a proper solution
7 years ago (2013-12-09 13:46:30 UTC) #2
mitica
For a group of elements like <div class="A"> <div class="B" style="mix-blend-mode: multiply"> <div class="C"> the ...
7 years ago (2013-12-10 14:51:18 UTC) #3
mitica
I've found a much simpler and better solution, please excuse me for the noise I ...
7 years ago (2013-12-12 09:54:58 UTC) #4
Stephen Chennney
lgtm
7 years ago (2013-12-17 14:26:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mitica@adobe.com/104663003/60001
7 years ago (2013-12-17 14:26:57 UTC) #6
commit-bot: I haz the power
Retried try job too often on linux_blink for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink&number=5615
7 years ago (2013-12-17 16:49:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mitica@adobe.com/104663003/60001
7 years ago (2013-12-17 17:14:58 UTC) #8
commit-bot: I haz the power
7 years ago (2013-12-17 18:04:06 UTC) #9
Message was sent while issue was closed.
Change committed as 164026

Powered by Google App Engine
This is Rietveld 408576698