Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 98543010: rac] Add re2 dependency to libaddressinput. (Closed)

Created:
7 years ago by please use gerrit instead
Modified:
7 years ago
Reviewers:
Evan Stade
CC:
chromium-reviews, roubert, lararennie
Visibility:
Public.

Description

[rac] Add re2 dependency to libaddressinput. This patch adds the re2 dependency to libaddressinput. The dependency will be used to validate postal code format of addresses. The addresses are provided by the user. The format regular expressions are from: https://i18napis.appspot.com/ssl-address For example, the US postal code has the following regular expression: \\d{5}([ \\-]\\d{4})? BUG=327046 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=241447

Patch Set 1 : #

Total comments: 1

Patch Set 2 : Merge. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -4 lines) Patch
M third_party/libaddressinput/chromium/cpp/README View 3 chunks +4 lines, -1 line 0 comments Download
M third_party/libaddressinput/chromium/cpp/libaddressinput.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
A + third_party/libaddressinput/chromium/cpp/re2.gyp View 1 1 chunk +11 lines, -3 lines 0 comments Download
M third_party/libaddressinput/libaddressinput.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
please use gerrit instead
Evan: PTAL. The file re2.gyp will be used in the upstream. It might change after ...
7 years ago (2013-12-13 22:22:15 UTC) #1
Evan Stade
https://codereview.chromium.org/98543010/diff/20001/third_party/libaddressinput/chromium/cpp/README File third_party/libaddressinput/chromium/cpp/README (right): https://codereview.chromium.org/98543010/diff/20001/third_party/libaddressinput/chromium/cpp/README#newcode42 third_party/libaddressinput/chromium/cpp/README:42: http://packages.debian.org/experimental/libre2-dev what... I don't think we can let chrome ...
7 years ago (2013-12-13 23:30:31 UTC) #2
please use gerrit instead
On 2013/12/13 23:30:31, Evan Stade wrote: > https://codereview.chromium.org/98543010/diff/20001/third_party/libaddressinput/chromium/cpp/README > File third_party/libaddressinput/chromium/cpp/README (right): > > https://codereview.chromium.org/98543010/diff/20001/third_party/libaddressinput/chromium/cpp/README#newcode42 ...
7 years ago (2013-12-14 00:13:47 UTC) #3
Evan Stade
but it's included as source, not as a prebuilt package.
7 years ago (2013-12-14 00:20:30 UTC) #4
please use gerrit instead
On 2013/12/14 00:20:30, Evan Stade wrote: > but it's included as source, not as a ...
7 years ago (2013-12-16 18:36:13 UTC) #5
Evan Stade
lgtm
7 years ago (2013-12-17 20:19:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rouslan@chromium.org/98543010/40001
7 years ago (2013-12-17 23:26:01 UTC) #7
commit-bot: I haz the power
7 years ago (2013-12-18 02:13:28 UTC) #8
Message was sent while issue was closed.
Change committed as 241447

Powered by Google App Engine
This is Rietveld 408576698