Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(889)

Issue 98543009: Make arguments to Element methods non-optional (Closed)

Created:
7 years ago by philipj_slow
Modified:
7 years ago
CC:
blink-reviews, arv+blink, eae+blinkwatch, dglazkov+blink, adamk+blink_chromium.org, watchdog-blink-watchlist_google.com, Inactive
Visibility:
Public.

Description

Make arguments to Element methods non-optional http://dom.spec.whatwg.org/#interface-element Only touch methods defined by the above spec. The added missing-arguments test passes in Firefox Nightly, and Opera 12.16. IE11 Release Preview passes all except getAttribute, removeAttribute and setAttribute, where it returns null/undefined instead of throwing. Taken together, this could break IE- and Chrome-only content. BUG=325922 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163374

Patch Set 1 #

Patch Set 2 : fix failing tests #

Messages

Total messages: 6 (0 generated)
philipj_slow
Probably depends on https://codereview.chromium.org/107093007/ to land first due to conflicts.
7 years ago (2013-12-06 21:13:52 UTC) #1
arv (Not doing code reviews)
LGTM
7 years ago (2013-12-06 21:16:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/98543009/1
7 years ago (2013-12-07 07:11:57 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink_rel&number=14829
7 years ago (2013-12-07 08:29:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/98543009/20001
7 years ago (2013-12-07 17:43:40 UTC) #5
commit-bot: I haz the power
7 years ago (2013-12-07 19:22:36 UTC) #6
Message was sent while issue was closed.
Change committed as 163374

Powered by Google App Engine
This is Rietveld 408576698