LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-speech-crash.html - Issue 98543009: Make arguments to Element methods non-optional

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-speech-crash.html

Issue 98543009: Make arguments to Element methods non-optional (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: fix failing tests Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <body>	2 <body>

3 <script src="../../../resources/js-test.js"></script>	3 <script src="../../../resources/js-test.js"></script>

4 <input type="time" value="11:59" onchange="test()" autofocus id="input">	4 <input type="time" value="11:59" onchange="test()" autofocus id="input">

5 <script>	5 <script>

6 jsTestIsAsync = true;	6 jsTestIsAsync = true;

7	7

8 function test() {	8 function test() {

9 document.body.appendChild(document.getElementById("input")).setAttribute('x- webkit-speech');	9 document.body.appendChild(document.getElementById("input")).setAttribute('x- webkit-speech', '');

10 testPassed('if not crashed.');	10 testPassed('if not crashed.');

11 finishJSTest();	11 finishJSTest();

12 }	12 }

13	13

14 description('There was a crash bug by setting x-webkit-speech in a change event handler.');	14 description('There was a crash bug by setting x-webkit-speech in a change event handler.');

15 document.body.onload = function() {	15 document.body.onload = function() {

16 if (!window.eventSender) {	16 if (!window.eventSender) {

17 debug('Click on the spin button');	17 debug('Click on the spin button');

18 } else {	18 } else {

19 eventSender.keyDown('upArrow');	19 eventSender.keyDown('upArrow');

20 }	20 }

21 };	21 };

22 </script>	22 </script>

23 </body>	23 </body>

OLD	NEW