Switch armv7 setting to arm_version=7 in v8 gyp files

Switch armv7 setting to arm_version==7 in v8 gyp files

BUG=chromium:234135
LOG=Y
R=jkummerow@chromium.org

Committed: http://code.google.com/p/v8/source/detail?r=18297

[Mostyn Bramley-Moore, 2013-12-06 22:07:42]

@Jakob: does this look OK to you?

(Are try jobs supposed to work for v8 patches?  I'm confused why this patch
fails to apply, the logs say that build/android.gypi doesn't exist, but it does
in my checkout).

[Fredrik Öhrn, 2013-12-11 09:19:12]

https://codereview.chromium.org/98543008/diff/1/build/android.gypi
File build/android.gypi (right):

https://codereview.chromium.org/98543008/diff/1/build/android.gypi#newcode172
build/android.gypi:172: ['target_arch=="arm" and arm_version==7', {
Should be arm_version < 7.

[Mostyn Bramley-Moore, 2013-12-11 09:46:02]

https://codereview.chromium.org/98543008/diff/1/build/android.gypi
File build/android.gypi (right):

https://codereview.chromium.org/98543008/diff/1/build/android.gypi#newcode172
build/android.gypi:172: ['target_arch=="arm" and arm_version==7', {
On 2013/12/11 09:19:12, Fredrik Öhrn wrote:
> Should be arm_version < 7.

Done.

[Jakob Kummerow, 2013-12-11 10:09:31]

Generally, s/armv7==1/arm_version==7/ is fine.
However, we intentionally had the unspecified default mode, meaning "let my
compiler decide". AFAIK this was mostly used by people building natively on ARM
machines. I don't want to break or degrade that use case.

Please also update the top-level Makefile,
https://code.google.com/p/v8/source/browse/branches/bleeding_edge/Makefile#141
ff. It would be nice to keep the armv7=true/false command-line flag for a while
for compatibility reasons, and add a new arm_version=FOO in addition.

Try jobs don't work for V8 patches.

[Mostyn Bramley-Moore, 2013-12-11 11:06:56]

On 2013/12/11 10:09:31, Jakob wrote:
> Generally, s/armv7==1/arm_version==7/ is fine.
> However, we intentionally had the unspecified default mode, meaning "let my
> compiler decide". AFAIK this was mostly used by people building natively on
ARM
> machines. I don't want to break or degrade that use case.

Changed the default of arm_version to "default", and added back conditions
corresponding to the original armv7=="default" checks.

> Please also update the top-level Makefile,
> https://code.google.com/p/v8/source/browse/branches/bleeding_edge/Makefile#141
> ff. It would be nice to keep the armv7=true/false command-line flag for a
while
> for compatibility reasons, and add a new arm_version=FOO in addition.

Done.  I wasn't quite sure what armv7=0 should map to, so I went with
arm_version=default, but I guess arm_version=6 might also be suitable- what do
you think?

[Jakob Kummerow, 2013-12-11 11:28:24]

LGTM with the comment below in answer to your question.

I can fix that and land this.

https://codereview.chromium.org/98543008/diff/60001/Makefile
File Makefile (right):

https://codereview.chromium.org/98543008/diff/60001/Makefile#newcode147
Makefile:147: GYPFLAGS += -Darm_version=default
IIUC, armv7=false used to result in armv6, so let's keep that behavior.

[Jakob Kummerow, 2013-12-11 11:54:58]

Oh, and also:

$ make arm.release
Makefile:447: *** missing `endif'.  Stop.

I've fixed that too, but I would appreciate it if you tested your patches before
uploading ;-)

[Jakob Kummerow, 2013-12-11 11:58:16]

Committed patchset #5 manually as r18297.

[Mostyn Bramley-Moore, 2013-12-11 12:19:55]

On 2013/12/11 11:54:58, Jakob wrote:
> Oh, and also:
> 
> $ make arm.release
> Makefile:447: *** missing `endif'.  Stop.
> 
> I've fixed that too, but I would appreciate it if you tested your patches
before
> uploading ;-)

Whoops, sorry about that.