Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Unified Diff: Makefile

Issue 98543008: Switch armv7 setting to arm_version=7 in v8 gyp files (Closed) Base URL: git://github.com/v8/v8.git@master
Patch Set: fixed Makefile Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/android.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Makefile
diff --git a/Makefile b/Makefile
index d2c9a9dfacb57fe7b76aeee26e6477d250afac52..b5882c64d3f1b6193646fb4a389a91e0f069d8bd 100644
--- a/Makefile
+++ b/Makefile
@@ -138,12 +138,17 @@ ifeq ($(deprecationwarnings), on)
GYPFLAGS += -Dv8_deprecation_warnings=1
endif
# arm specific flags.
-# armv7=false/true
+# arm_version=<number | "default">
+ifneq ($(strip $(arm_version)),)
+ GYPFLAGS += -Darm_version=$(arm_version)
+else
+# Deprecated (use arm_version instead): armv7=false/true
ifeq ($(armv7), false)
- GYPFLAGS += -Darmv7=0
+ GYPFLAGS += -Darm_version=6
else
ifeq ($(armv7), true)
- GYPFLAGS += -Darmv7=1
+ GYPFLAGS += -Darm_version=7
+endif
endif
endif
# vfp2=off. Deprecated, use armfpu=
« no previous file with comments | « no previous file | build/android.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698