chrome/renderer/extensions/page_actions_custom_bindings.cc - Issue 98543004: Remove usage of deprecated V8 APIs from c/r/extensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/extensions/page_actions_custom_bindings.cc

Issue 98543004: Remove usage of deprecated V8 APIs from c/r/extensions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/extensions/page_actions_custom_bindings.cc

diff --git a/chrome/renderer/extensions/page_actions_custom_bindings.cc b/chrome/renderer/extensions/page_actions_custom_bindings.cc

index eedb036dda84aa464bcab267c190376452348661..c413d5ec68e2080ade21f839b3c0de7ea71f7705 100644

--- a/chrome/renderer/extensions/page_actions_custom_bindings.cc

+++ b/chrome/renderer/extensions/page_actions_custom_bindings.cc

@@ -31,7 +31,7 @@ void PageActionsCustomBindings::GetCurrentPageActions(

dispatcher_->extensions()->GetByID(extension_id);

CHECK(extension);

- v8::Local<v8::Array> page_action_vector = v8::Array::New();

+ v8::Local<v8::Array> page_action_vector = v8::Array::New(args.GetIsolate());

if (ActionInfo::GetPageActionInfo(extension)) {

std::string id = ActionInfo::GetPageActionInfo(extension)->id;

page_action_vector->Set(v8::Integer::New(0),