Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7426)

Unified Diff: chrome/renderer/extensions/object_backed_native_handler.cc

Issue 98543004: Remove usage of deprecated V8 APIs from c/r/extensions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/extensions/object_backed_native_handler.cc
diff --git a/chrome/renderer/extensions/object_backed_native_handler.cc b/chrome/renderer/extensions/object_backed_native_handler.cc
index 46840ba8cb708250c36029bcf83aa993b218f9b0..427854bd3b869faef70556adc367611042cee6f8 100644
--- a/chrome/renderer/extensions/object_backed_native_handler.cc
+++ b/chrome/renderer/extensions/object_backed_native_handler.cc
@@ -46,7 +46,7 @@ void ObjectBackedNativeHandler::Router(
// See comment in header file for why we do this.
if (handler_function_value.IsEmpty() ||
handler_function_value->IsUndefined()) {
- console::Error(v8::Context::GetCalling(),
+ console::Error(args.GetIsolate()->GetCallingContext(),
"Extension view no longer exists");
return;
}
@@ -69,7 +69,8 @@ void ObjectBackedNativeHandler::RouteFunction(
v8::External::New(isolate, new HandlerFunction(handler_function)));
v8::Handle<v8::FunctionTemplate> function_template =
v8::FunctionTemplate::New(Router, local_data);
- object_template_.NewHandle(isolate)->Set(name.c_str(), function_template);
+ object_template_.NewHandle(isolate)
+ ->Set(isolate, name.c_str(), function_template);
router_data_.push_back(UnsafePersistent<v8::Object>(&data));
}

Powered by Google App Engine
This is Rietveld 408576698